Skip to content

[Translation] Add --prefix and --no-fill to translation page #20352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Oct 27, 2024

I added documentation for --no-fill option and --prefix option in Translations page.

--no-fill option is a new feature in Symfony 7.2.

Closes #20343

@carsonbot carsonbot added this to the 7.2 milestone Oct 27, 2024
translation.rst Outdated

.. code-block:: terminal

# change default prefix for new translations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# change default prefix for new translations
# changes default prefix for new translations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I also shorten the comment to "changes default prefix"

translation.rst Outdated
# change default prefix for new translations
$ php bin/console translation:extract --force --prefix="NEW_" fr

# leave new translation empty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# leave new translation empty
# leaves new translations empty

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

text as the message, prefixed by ``__``. You can customize this prefix using
the ``--prefix`` option.

If you want to leave new translations empty, use the ``--no-fill`` option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a versionadded directive for this new option ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I put directive after example.

@carsonbot carsonbot changed the title Add --prefix and --no-fill to translation page [Translation] Add --prefix and --no-fill to translation page Oct 28, 2024
@javiereguiluz javiereguiluz merged commit 4e83e9a into symfony:7.2 Oct 28, 2024
3 checks passed
@javiereguiluz
Copy link
Member

Thanks @jawira and congrats on your first Symfony Docs contribution 🎉

@jawira jawira deleted the no-fill branch October 28, 2024 20:51
javiereguiluz added a commit that referenced this pull request Oct 30, 2024
… --prefix option (xabbuh)

This PR was merged into the 5.4 branch.

Discussion
----------

[Translation] document the translation:extract command's --prefix option

backport from #20352

Commits
-------

942396b document the translation:extract command's --prefix option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants